Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor issue, queryissue pkgs #2044

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Refactor issue, queryissue pkgs #2044

merged 7 commits into from
Dec 10, 2024

Conversation

makalaaneesh
Copy link
Collaborator

@makalaaneesh makalaaneesh commented Dec 6, 2024

Describe the changes in this pull request

Some more refactoring on top of comments from #1873

  • Move issue definitions from issue pkg into queryissue pkg
  • Move IssueInstance from issue pkg into queryIssue pkg.
  • Rename IssueInstance to queryIssue
  • Put queryissue and queryparser under a common folder query
image

Describe if there are any user-facing changes

N/A

How was this pull request tested?

N/A. Existing tests suffice.

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB No
Name registry json No
Data File Descriptor Json No
Export Snapshot Status Json No
Import Data State No
Export Status Json No
Data .sql files of tables No
Export and import data queue No
Schema Dump No
AssessmentDB No
Sizing DB No
Migration Assessment Report Json No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables No

@makalaaneesh makalaaneesh marked this pull request as ready for review December 6, 2024 09:50
@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
limitations under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the prefix query in the directory names of queryissue, queryparser ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the query directory is just better file organization, it does not translate to any form of nesting of packages. If there was indeed some form of nesting, I agree; it would make sense to remove the "query" prefix. But since these are top-level packages, I wanted to stick to the pattern of keeping the folder name same as the package name.

Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makalaaneesh makalaaneesh merged commit c69f443 into main Dec 10, 2024
33 checks passed
@makalaaneesh makalaaneesh deleted the aneesh/pkg-refactor branch December 10, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants