Test and Update MInVersionsFixedIn for issue of ALTER PARTITIONED TABLE ADD PRIMARY KEY #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makalaaneesh
changed the title
priyanshi-yb
approved these changes
Dec 11, 2024
| ybVersion := os.Getenv("YB_VERSION") | ||
| if ybVersion == "" { | ||
| panic("YB_VERSION env variable is not set. Set YB_VERSIONS=2024.1.3.0-b105 for example") | ||
| } | ||
|
|
||
| ybVersionWithoutBuild := strings.Split(ybVersion, "-")[0] |
There was a problem hiding this comment.
Q: so our --target-db-version can only accept the version without build number only?
Just asking this if we are mentioning this in flag's help msg ?
There was a problem hiding this comment.
So, right now it does accept build number as well, but the problem is that 2024.2.0.0-b145 is considered to be > 2024.2.0.0 (which is defined in the MinVersionsFixedIn).
I'm planning to raise another PR preventing users from passing the build number in the input to prevent these kinds of issues.
| ) PARTITION BY RANGE (order_date); | ||
| ALTER TABLE orders2 ADD PRIMARY KEY (order_id,order_date)`) | ||
|
|
||
| assertErrorCorrectlyThrownForIssueForYBVersion(t, err, "changing primary key of a partitioned table is not yet implemented", alterTableAddPKOnPartitionIssue, testYbVersion) |
There was a problem hiding this comment.
nit: no need to pass testYbVersion as its global var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Describe if there are any user-facing changes
How was this pull request tested?
Does your PR have changes that can cause upgrade issues?