Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send target-db-version, MinimumVersionsFixedIn details for assessment/analyze-schema reports to controlplane/callhome #2049

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

makalaaneesh
Copy link
Collaborator

@makalaaneesh makalaaneesh commented Dec 9, 2024

Describe the changes in this pull request

In assess-migration

  • yugabyted control plane
    • send target-db-version
    • include MinFixVersion for all issues
  • callhome
    • send target-db-version

In analyze-schema

  • yugabyted control plane (Already done because we send the entire schema report)
    • send target-db-version
    • include MinFixVersion for all issues
  • callhome
    • send target-db-version

Describe if there are any user-facing changes

How was this pull request tested?

Does your PR have changes that can cause upgrade issues?

Changes to callhome and yugabyted. Both are changes to the phase payload, no change in table schema.
Overall, should not cause upgrade issues.

Component Breaking changes?
MetaDB Yes/No
Name registry json Yes/No
Data File Descriptor Json Yes/No
Export Snapshot Status Json Yes/No
Import Data State Yes/No
Export Status Json Yes/No
Data .sql files of tables Yes/No
Export and import data queue Yes/No
Schema Dump Yes/No
AssessmentDB Yes/No
Sizing DB Yes/No
Migration Assessment Report Json Yes/No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables Yes/No

@makalaaneesh makalaaneesh marked this pull request as ready for review December 10, 2024 09:04
@@ -1224,6 +1224,7 @@ type AssessMigrationDBConfig struct {
type AssessMigrationPayload struct {
PayloadVersion string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the payload version as we add the TargetDBVersion struct?

yb-voyager/src/callhome/diagnostics_test.go Show resolved Hide resolved
Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makalaaneesh makalaaneesh merged commit e5e8f9c into main Dec 12, 2024
34 checks passed
@makalaaneesh makalaaneesh deleted the aneesh/version-issues-callhome-controlplane branch December 12, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants