Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few more commands to the exportDirInitialisedCheckNeededList #2072

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ShivanshGahlot
Copy link
Collaborator

Describe the changes in this pull request

Added a few more commands to the exportDirInitialisedCheckNeededList to ensure they don't throw a segmentation fault error when run on an empty export dir:

"yb-voyager analyze-schema"
"yb-voyager import data"
"yb-voyager import data to target"
"yb-voyager import data to source"
"yb-voyager import data to source-replica"
"yb-voyager export data from target"

Describe if there are any user-facing changes

For the commands mentioned above, if run on an empty export dir the following message will be displyed:
image

How was this pull request tested?

Tested it manually by running the command on an empty export dir

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB No
Name registry json No
Data File Descriptor Json No
Export Snapshot Status Json No
Import Data State No
Export Status Json No
Data .sql files of tables No
Export and import data queue No
Schema Dump No
AssessmentDB No
Sizing DB No
Migration Assessment Report Json No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables No

…to ensure they don't throw a segmentation fault error when run on an empty export dir
Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShivanshGahlot ShivanshGahlot merged commit 7578488 into main Dec 13, 2024
34 checks passed
@ShivanshGahlot ShivanshGahlot deleted the shivansh/fix-commands-segmentation-fault branch December 13, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants