Update handling of unlogged tables as per 2024.2 #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert.NoError(t, err) | ||
|
|
||
| defer conn.Close(context.Background()) | ||
| _, err = conn.Exec(ctx, "CREATE UNLOGGED TABLE unlogged_table (a int)") | ||
| // in 2024.2, UNLOGGED no longer throws an error, just a notice | ||
| if noticeFound { |
There was a problem hiding this comment.
I see you have changed the assertion to assert based on target-db-version if its fixed or not, but should we also keep the notice found check also?
There was a problem hiding this comment.
I didn't see the point of keeping the notice check around. we are anyway printing all notices for all DDLs that are run. So we just need to now test that it does not throw any error. RIght?
migtests/tests/pg/assessment-report-test/expectedAssessmentReport.json
Outdated
Show resolved
Hide resolved
priyanshi-yb
approved these changes
Dec 16, 2024
| assert.NoError(t, err) | ||
|
|
||
| defer conn.Close(context.Background()) | ||
| _, err = conn.Exec(ctx, "CREATE UNLOGGED TABLE unlogged_table (a int)") | ||
| // in 2024.2, UNLOGGED no longer throws an error, just a notice | ||
| if noticeFound { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Describe if there are any user-facing changes
import-schema output will now have the NOTICEs printed out if received from psql.
How was this pull request tested?
Does your PR have changes that can cause upgrade issues?