Skip to content

Commit

Permalink
Pin icechunk for now and fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
abarciauskas-bgse committed Jan 10, 2025
1 parent dd76460 commit 6ddd407
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ci/upstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ dependencies:
- fsspec
- pip
- pip:
- icechunk>=0.1.0a8 # Installs zarr v3 as dependency
- icechunk==0.1.0a8 # Installs zarr v3 beta 3 as dependency
# - git+https://github.com/fsspec/kerchunk@main # kerchunk is currently incompatible with zarr-python v3 (https://github.com/fsspec/kerchunk/pull/516)
- imagecodecs-numcodecs==2024.6.1
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ hdf_reader = [
"numcodecs"
]
icechunk = [
"icechunk>=0.1.0a8",
"icechunk==0.1.0a8",
]
test = [
"codecov",
Expand Down
4 changes: 3 additions & 1 deletion virtualizarr/tests/test_writers/test_icechunk.py
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,9 @@ async def test_append_with_multiple_root_arrays(
"time/c/0", prototype=default_buffer_prototype()
)
) == first_time_chunk_before_append
new_ds = open_zarr(icechunk_filestore_append, consolidated=False, zarr_format=3)
new_ds = open_zarr(
icechunk_filestore_append.store, consolidated=False, zarr_format=3
)

expected_ds1, expected_ds2 = open_dataset(filepath1), open_dataset(filepath2)
expected_ds = concat([expected_ds1, expected_ds2], dim="time")
Expand Down

0 comments on commit 6ddd407

Please sign in to comment.