-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append to icechunk stores #272
Merged
Merged
Changes from 85 commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
d3a4048
Initial attempt at appending
abarciauskas-bgse 5d5f9e2
Working on tests for generate chunk key function
abarciauskas-bgse 360ea14
Linting
abarciauskas-bgse d3c2851
Refactor gen virtual dataset method
abarciauskas-bgse a7a1e50
Fix spelling
abarciauskas-bgse 0365a45
Linting
abarciauskas-bgse 5846d7e
Linting
abarciauskas-bgse 66bbd6e
Linting
abarciauskas-bgse 000c68f
Passing compression test
abarciauskas-bgse 3131167
Merge branch 'main' into icechunk-append
TomNicholas 5906687
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 80e4dcb
merge main and linting
abarciauskas-bgse 672e5e1
linting
abarciauskas-bgse 0fce71f
Fix test failing due to incorrect dtype
abarciauskas-bgse 41f80f8
Fix conflict in conftest
abarciauskas-bgse e60437f
linting
abarciauskas-bgse de2f135
Linting
abarciauskas-bgse c8a46a6
Remove obsolete test file for appending
abarciauskas-bgse 7663ad7
Create netcdf4 files factor in conftest
abarciauskas-bgse 1d704ff
Linting
abarciauskas-bgse af5f57d
Refactor to use combineable zarr arrays
abarciauskas-bgse 6f4cfd9
linting
abarciauskas-bgse 98c7052
Implement no append dim test
abarciauskas-bgse f36adf2
Add test for when append dim is not in dims
abarciauskas-bgse e922ccd
Fix mypy errors
abarciauskas-bgse ca80cb2
type ignore import untyped zarr
abarciauskas-bgse f186d4f
Use Union type for check_combineable_zarr_arrays arg
abarciauskas-bgse 2a90d9c
Fix import
abarciauskas-bgse 0253a8a
Fix imports for get_codecs
abarciauskas-bgse 7369fcf
use new factory in test
abarciauskas-bgse 2949493
Remove need for dask in fixture
abarciauskas-bgse c305dad
Fix for when zarr is not installed
abarciauskas-bgse aaede73
Address test failures
abarciauskas-bgse 5d685c6
Add get_codecs file
abarciauskas-bgse d704de2
Add dask to upstream
abarciauskas-bgse 29ca87c
Merge branch 'main' into icechunk-append
abarciauskas-bgse d84c58c
Remove dependency on dask and h5netcdf engine
abarciauskas-bgse f19e3d1
Merge branch 'icechunk-append' of github.com:zarr-developers/virtuali…
abarciauskas-bgse 2505d9e
Remove obsolete comment
abarciauskas-bgse aaa7f01
Remove duplicate zarr array type check
abarciauskas-bgse 5071ed7
Move codecs module and type output
abarciauskas-bgse 7067b43
Actually add codecs file
abarciauskas-bgse f867e14
Merge branch 'main' into icechunk-append
abarciauskas-bgse 0ec5084
Fix merge mistake
abarciauskas-bgse 5630b34
Ignore import untyped
abarciauskas-bgse 2fd7fea
Merge branch 'main' into icechunk-append
abarciauskas-bgse d93f2ce
Add tests for codecs
abarciauskas-bgse b21daca
Merge branch 'icechunk-append' of github.com:zarr-developers/virtuali…
abarciauskas-bgse a6c2ccb
Resolve mypy errors
abarciauskas-bgse 98a676d
Fix test
abarciauskas-bgse db3313f
Import zarr in function
abarciauskas-bgse 145ed0e
Use existing importorskip function
abarciauskas-bgse 80cd358
Modify comments
abarciauskas-bgse 3035f05
Comment updates and spelling of combinable
abarciauskas-bgse 28e05db
Revert change to check compatible encoding
abarciauskas-bgse 2c07cdf
Ignore zarr untyped import errors
abarciauskas-bgse 19837b2
Implement a manifest.utils module
abarciauskas-bgse 532ff38
pass the array into resize_array
abarciauskas-bgse 24f7274
Refactor resize_array
abarciauskas-bgse 113cd2c
Remove unnecessary zarr imports
abarciauskas-bgse 61ce01a
Add pinned version of icechunk as an optional dependency
abarciauskas-bgse defe7d9
Add append_dim in docstring
abarciauskas-bgse cb82d40
Kludgy solution to v2 v3 codecs difference
abarciauskas-bgse 2f6cbc2
Add normalize to v3 parameter
abarciauskas-bgse a442fa4
Add more info to docstring
abarciauskas-bgse 7d1bb36
Fix typing issues
abarciauskas-bgse 39677e8
Add decorator for zarr python v3 test
abarciauskas-bgse 5fa7177
Fix mypy and ruff errors
abarciauskas-bgse e109c0d
Only append if append_dim in dims
abarciauskas-bgse eb0e8f2
Add example notebook
abarciauskas-bgse fd2df4e
Add a runtime
abarciauskas-bgse 1659d21
Add failing test
abarciauskas-bgse f5976d1
Fix multiple appends
abarciauskas-bgse f903291
Fix test error message
abarciauskas-bgse c109626
Add new cell to notebook to display original time chunk
abarciauskas-bgse dd9c381
Upgrade icechunk to 1.0.0a5
abarciauskas-bgse 7c1fcfa
Upgrade icechunk in upstream.yml
abarciauskas-bgse 1bb2ad0
Updated notebook with kechunk comment an upgraded icechunk version
abarciauskas-bgse 64f2478
Modify test so it fails without updated icechunk
abarciauskas-bgse 13de8d3
Update icechunk dependency
abarciauskas-bgse 4a65e5a
Fix mypy errors
abarciauskas-bgse 64e5277
update icechunk version in pyproject
abarciauskas-bgse d6ef97f
Merge branch 'main' into icechunk-append
abarciauskas-bgse 9d2f7f8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 53045c3
Remove obsolete comment
abarciauskas-bgse b21a0e5
Use icechunk 0.1.0a7
abarciauskas-bgse 208e83e
Updated notebook
abarciauskas-bgse 79e0c1b
Updated notebook
abarciauskas-bgse e38823c
print store
abarciauskas-bgse ad17b83
Update notebook (#327)
mpiannucci 8b9a830
Add append to examples
abarciauskas-bgse 3f9f58c
Add to releases.rst
abarciauskas-bgse 8496359
Revert change to .gitignore
abarciauskas-bgse 7dc9186
Merge branch 'main' into icechunk-append
TomNicholas 491b701
Update ci/upstream.yml
abarciauskas-bgse 94ef469
Update pyproject.toml
abarciauskas-bgse fad188b
Update virtualizarr/tests/test_writers/test_icechunk.py
abarciauskas-bgse 8df67e9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 258c92f
Update virtualizarr/accessor.py
abarciauskas-bgse 84a4d01
Separate out multiple arrays test
abarciauskas-bgse 299f580
Merge branch 'icechunk-append' of github.com:zarr-developers/virtuali…
abarciauskas-bgse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are up to a7 now, no api changes from 6 to 7