Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test FITS reader on Hubble Space Telescope data #363

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Dec 21, 2024

Small bugfix for the FITS reader, tested by trying to read one of the FITS files stored in AWS comprising the Hubble Space Telescope data archive.

Also renames the @network test decorator to @requires_network.

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst

@TomNicholas TomNicholas merged commit d4f6b98 into main Jan 9, 2025
10 of 11 checks passed
@TomNicholas TomNicholas deleted the test_fits_hubble branch January 9, 2025 15:08
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.08%. Comparing base (7f1232f) to head (1a8896e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #363       +/-   ##
===========================================
+ Coverage   58.80%   79.08%   +20.28%     
===========================================
  Files          32       32               
  Lines        1903     1903               
===========================================
+ Hits         1119     1505      +386     
+ Misses        784      398      -386     
Files with missing lines Coverage Δ
virtualizarr/readers/fits.py 85.71% <100.00%> (+42.85%) ⬆️

... and 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant