-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Xarray to 2025.1.1 and icechunk to 0.1.0a10 in upstream #375
base: main
Are you sure you want to change the base?
Conversation
norlandrhagen
commented
Jan 9, 2025
- Tests passing
Hey there @mpiannucci, @TomNicholas and I just bumped the icechunk and Xarray versions and we're seeing some failures on the upstream CI. Wondering if you have any insight! |
zarr 3 comes with a number of changes
|
Hey, can you bump icechunk version to 0.1.0a11, which has added azure blob support? I'm interested in trying out writing virtual zarr store into azure blob but got blocked by the same issue causing the CI failures. Is there an estimate on when we can expect this PR to be merged? |
@norlandrhagen just FYI: This is the branch I am using for icechunk until we can come up with a more complete design for refactoring for zarr-python 3.0 |
Thanks @abarciauskas-bgse! @redcliff we're in a tricky spot right now, with a bunch of backwards-incompatible and mutually-exclusive changes in our dependencies Zarr-python v3, Icechunk, and Kerchunk. Whilst it should be possible to make things work with some hacky branches right now, if you would rather avoid that rabbit hole then it will likely take us a few weeks to get everything working again on up-to-date released branches. Can I ask what file format you're hoping to Virtualize? That can affect which dependencies you need which affects how easy it is to get things working right now. |
@TomNicholas, @redcliff and I would like to virtualize NetCDF4 and HDF5 files types. They are the primary n-dimensional array datatypes we host on Planetary Computer. We can wait until the dependencies stabilize. My end goal is for us to be able to do the following:
If I understand the sequence of events correctly
Can we help in any way? |
Hey @ghidalgo3! Yes that's all correct, but with the additional complication that we can't even pin any Zarr-python version >=3.0.0 in main yet (not even the pre-release) because some of our readers (and tests) are still coupled to kerchunk, an optional dependency that currently requires zarr-python<3.0.0. However in your case if you use the newer
Someone needs to rewrite the codec pipeline code to work with the released version of Zarr-python, and as you guys so kindly wrote the v2-compatible version of that then you would be great people to update it 😄 For the purposes of testing that you could just pin Zarr-python>=3.0.0 in that branch, even though that will currently break kerchunk-reliant tests, as depending on >=3.0.0.0 is the end state we're aiming for anyway. |
I'm using the dmrpp reader so I'm not 100% sure my branch will work with the HDFVirtualBackend reader |