Upgraded to bevy 0.14 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a regression for 'minimal' and 'movement' indeed. But this is fixed with my latest commit now! |
Rezan7CC
commented
Aug 16, 2024
examples/krypta.rs
Outdated
| @@ -52,7 +52,6 @@ fn main() | |||
| }), | |||
| BevyMagicLight2DPlugin, | |||
| ResourceInspectorPlugin::<BevyMagicLight2DSettings>::new(), | |||
| WorldInspectorPlugin::new(), | |||
There was a problem hiding this comment.
Removed WorldInspectorPlugin for krypta again (I added it in the previous commit) because none of the examples have that one enabled by default
Rezan7CC
commented
Aug 16, 2024
| @@ -7,7 +7,7 @@ fn main() | |||
| { | |||
| // Basic setup. | |||
| App::new() | |||
| .insert_resource(ClearColor(Color::rgb_u8(255, 255, 255))) | |||
There was a problem hiding this comment.
rgb_u8 is deprecated in bevy 0.14 now
Rezan7CC
commented
Aug 16, 2024
| @@ -160,7 +160,7 @@ pub fn system_extract_pipeline_assets( | |||
| { | |||
| if let Ok((camera, camera_global_transform)) = query_camera.get_single() { | |||
| let camera_params = gpu_pipeline_assets.camera_params.get_mut(); | |||
| let projection = camera.projection_matrix(); | |||
| let projection = camera.clip_from_view(); | |||
There was a problem hiding this comment.
Same method, different name
Rezan7CC
commented
Aug 16, 2024
| LAYER_OBJECTS_ID, | ||
| ]; | ||
|
|
||
| pub const LAYER_POST_PROCESSING_ID: Layer = 42; |
There was a problem hiding this comment.
The number of layers is unlimited now. I chose '42' just as some arbitrary large number
|
Cargo clippy and cargo fmt commits are included here to try to fix the trunk check so the PR can be merged |
|
/trunk merge |
zaycev
approved these changes
Aug 25, 2024
Update merge config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Krypta.rs looks good.
However for minimal.rs I only see the 3 colored lights with a sharp fall-off (black otherwise).
And movement.rs is a black-screen for me.
I did not check what those examples looked like before the upgrade, will have a look and compare soon.