Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression #68

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix regression #68

merged 2 commits into from
Aug 30, 2024

Conversation

tigerplush
Copy link
Collaborator

Closes #64

@trunk-io Trunk.io
Copy link

trunk-io bot commented Aug 30, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@tigerplush tigerplush mentioned this pull request Aug 30, 2024
Closed
@CarsonBurke
Copy link
Contributor

CarsonBurke commented Aug 30, 2024 •
edited
Loading

My testing with the benchmark mentioned in #65 shows this completely fixes the regression. This regression fix is only tangentially related to #64 in that it reduces the ability for an observer to notice the trailing lights with higher FPS.

zaycev
zaycev approved these changes Aug 30, 2024
View reviewed changes
Copy link
Owner

@zaycev zaycev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you @tigerplush

@zaycev zaycev merged commit 3a8c250 into main Aug 30, 2024
1 check failed
@uzunenx uzunenx mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaycev zaycev zaycev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: lights now trail movement
3 participants
@tigerplush @CarsonBurke @zaycev