Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: small vite+template improvements #195

Merged
merged 5 commits into from
Nov 8, 2024
Merged

feat: small vite+template improvements #195

merged 5 commits into from
Nov 8, 2024

Conversation

tpluscode
Copy link
Contributor

With this merged, I think I will remove the prerelease flags from packages

@tpluscode tpluscode requested a review from giacomociti November 7, 2024 12:55
Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 87f4e96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@kopflos-cms/vite Patch
@kopflos-labs/html-template Patch
@kopflos-cms/core Patch
example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 93.99%. Comparing base (6fb4851) to head (87f4e96).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
packages/vite/index.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   94.44%   93.99%   -0.46%     
==========================================
  Files          38       38              
  Lines        1566     1581      +15     
  Branches      197      199       +2     
==========================================
+ Hits         1479     1486       +7     
- Misses         86       94       +8     
  Partials        1        1              
Flag Coverage Δ
@kopflos-cms/core 96.42% <100.00%> (+0.14%) ⬆️
@kopflos-cms/express 86.49% <92.30%> (+0.07%) ⬆️
@kopflos-cms/plugin-deploy-resources 59.23% <84.61%> (+0.16%) ⬆️
@kopflos-cms/serve-file 100.00% <ø> (ø)
@kopflos-cms/vite 68.33% <50.00%> (-1.17%) ⬇️
@kopflos-labs/handlebars 77.49% <100.00%> (+0.31%) ⬆️
@kopflos-labs/html-template 83.83% <100.00%> (+0.29%) ⬆️
sparql-path-parser 95.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode tpluscode merged commit 97c588a into master Nov 8, 2024
52 of 54 checks passed
@tpluscode tpluscode deleted the vite-base-path branch November 8, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant