Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async Select and Consume #39

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Add async Select and Consume #39

merged 4 commits into from
Feb 23, 2023

Conversation

d-nery
Copy link
Member

@d-nery d-nery commented Feb 3, 2023

This PR also moves Consume from the class to the Extensions and all respective tests from MaybeTests to MaybeExtensionsTests

Solves #12

alercunha
alercunha requested changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@alercunha alercunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider including more async methods: Or, OrMaybe

erickotsuka
erickotsuka requested changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@erickotsuka erickotsuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have tests for OrAsync and OrMaybeAsync with a null argument, ensuring it throws the expected exception, like we have for Or and OrMaybe.

@d-nery d-nery requested a review from erickotsuka February 22, 2023 13:37
@d-nery d-nery merged commit 15c8958 into release/1.0 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickotsuka erickotsuka erickotsuka approved these changes

@alercunha alercunha alercunha approved these changes

@spliner spliner Awaiting requested review from spliner

@dgmagno dgmagno Awaiting requested review from dgmagno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-nery @alercunha @erickotsuka