Revert "Add the correct input type attribute to edit inputs"

This reverts commit 6fdda51.
zbycz · Oct 16, 2024 · 5714512 · 5714512
1 parent ae013fc
commit 5714512
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 44 deletions.
diff --git a/src/components/FeaturePanel/EditDialog/EditContent/MajorKeysEditor.tsx b/src/components/FeaturePanel/EditDialog/EditContent/MajorKeysEditor.tsx
@@ -9,7 +9,7 @@ import { useEditDialogContext } from '../../helpers/EditDialogContext';
 import { useEditContext } from '../EditContext';
 import { OpeningHoursEditor } from './OpeningHoursEditor/OpeningHoursEditor';
 import styled from '@emotion/styled';
-import { CharacterCount, getInputTypeForKey } from './helpers';
+import { CharacterCount } from './helpers';
 
 export const majorKeys = [
   'name',
@@ -21,7 +21,7 @@ export const majorKeys = [
 
 const MAX_INPUT_LENGTH = 255;
 
-const getData = (numberOfWikimediaItems: number) => {
+const getData = (numberOfWikimediaItems) => {
   const wikimediaCommonTags = Array(numberOfWikimediaItems)
     .fill('')
     .reduce((acc, _, index) => {
@@ -47,30 +47,19 @@ const InputContainer = styled.div`
   position: relative;
 `;
 
-type TextFieldProps = {
-  k: string;
-  label: string;
-  onChange: React.ChangeEventHandler<HTMLInputElement | HTMLTextAreaElement>;
-  value?: string;
-  autoFocus?: boolean;
-};
-
 const TextFieldWithCharacterCount = ({
   k,
   label,
   autoFocus,
   onChange,
   value,
-}: TextFieldProps) => {
+}) => {
   const [isFocused, setIsFocused] = useState(false);
-  const inputType = getInputTypeForKey(k);
-
   return (
     <InputContainer>
       <TextField
         label={label}
-        type={inputType}
-        multiline={inputType === 'text'}
+        multiline
         value={value}
         InputLabelProps={{ shrink: true }}
         variant="outlined"

diff --git a/src/components/FeaturePanel/EditDialog/EditContent/TagsEditor/ValueInput.tsx b/src/components/FeaturePanel/EditDialog/EditContent/TagsEditor/ValueInput.tsx
@@ -3,7 +3,6 @@ import { useEditDialogContext } from '../../../helpers/EditDialogContext';
 import { useEditContext } from '../../EditContext';
 import { IconButton, Stack, TextField } from '@mui/material';
 import DeleteIcon from '@mui/icons-material/Delete';
-import { getInputTypeForKey } from '../helpers';
 
 const useHidableDeleteButton = () => {
   const buttonRef = useRef<HTMLButtonElement>(null);
@@ -35,10 +34,7 @@ const DeleteButton = ({ deleteButton, index }: DeleteButtonProps) => {
     setTagsEntries((state) => state.toSpliced(index, 1));
   };
 
-  if (!deleteButton.shown) {
-    return null;
-  }
-  return (
+  return deleteButton.shown ? (
     <IconButton
       size="small"
       onClick={onClick}
@@ -47,7 +43,7 @@ const DeleteButton = ({ deleteButton, index }: DeleteButtonProps) => {
     >
       <DeleteIcon fontSize="small" />
     </IconButton>
-  );
+  ) : null;
 };
 
 type Props = { index: number };
@@ -69,7 +65,6 @@ export const ValueInput = ({ index }: Props) => {
   return (
     <Stack direction="row" spacing={1} alignItems="center">
       <TextField
-        type={getInputTypeForKey(currentKey)}
         value={currentValue}
         onChange={handleChange}
         fullWidth

diff --git a/src/components/FeaturePanel/EditDialog/EditContent/helpers.tsx b/src/components/FeaturePanel/EditDialog/EditContent/helpers.tsx
@@ -27,25 +27,3 @@ export const CharacterCount = ({
       </Stack>
     </CharacterCountContainer>
   ) : null;
-
-export const getInputTypeForKey = (key: string) => {
-  switch (key) {
-    case 'fax':
-    case 'phone':
-    case 'mobile':
-    case 'contact:phone':
-    case 'contact:whatsapp':
-    case 'contact:mobile':
-    case 'contact:tty':
-    case 'contact:sms':
-    case 'contact:fax':
-      return 'tel';
-    case 'contact:website':
-    case 'website':
-      return 'url';
-    case 'contact:email':
-    case 'email':
-      return 'email';
-  }
-  return 'text';
-};