Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditDialog: refactor TagsEditor #680

Merged
merged 11 commits into from
Oct 14, 2024
Merged

EditDialog: refactor TagsEditor #680

merged 11 commits into from
Oct 14, 2024

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Oct 14, 2024

Description

  • refactored tags in EditContext to tagsEntries. Otherwise key could not have been edited.
  • inspired by iD tags editor
  • added delete icon, empty key check and duplicate check

Example links

  • any feature

Screenshots

Checklist

  • dark mode / light mode
  • mobile / desktop
  • server-side-rendering (SSR)

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Oct 14, 2024 1:50pm

@zbycz zbycz merged commit 57819b1 into master Oct 14, 2024
3 checks passed
@zbycz zbycz deleted the tags-editor branch October 14, 2024 14:18
Copy link

sentry-io bot commented Oct 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator)) /[[...all]] View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant