Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid URL silently #699

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Handle invalid URL silently #699

merged 5 commits into from
Nov 15, 2024

Conversation

kudlav
Copy link
Contributor

@kudlav kudlav commented Oct 19, 2024

Description

Only a blank screen with error message is displayed when user visit invalid URL : This page could not be found..

No logo nor link back to the app.

old 404 page (light theme):

old 404 page (dark theme):

Possible solutions:

  • ignore invalid URL and render app like / URL (this PR)
  • display error toast and redirect to /
  • implement and display user friendly Error 404 page

Example links

Screenshots

Checklist

  • dark mode / light mode
  • mobile / desktop
  • server-side-rendering (SSR)

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Nov 15, 2024 1:08pm

@kudlav kudlav marked this pull request as ready for review October 19, 2024 20:02
@Dlurak
Copy link
Collaborator

Dlurak commented Nov 2, 2024

Let's wait about one week for @zbycz so we can get his opinion which of the three proposed solutions he prefers

@zbycz
Copy link
Owner

zbycz commented Nov 9, 2024

I agree with the idea of this PR. 👍 I would choose option number one, but also perhaps emit a warning toast, so the user knows that something is wrong in URL.

I will have to check the code once I get to my PC.

@zbycz zbycz enabled auto-merge (squash) November 15, 2024 13:04
@zbycz zbycz merged commit 8aed554 into zbycz:master Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants