Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map: add OpenFreeMap provider #770

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Map: add OpenFreeMap provider #770

merged 1 commit into from
Nov 15, 2024

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Nov 15, 2024

Lets evaluate how it works. If it needs any updates to style etc.

Added as separate layer in LayerSwitcher:
image

Issue:
#693

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Nov 15, 2024 9:02am

@zbycz zbycz enabled auto-merge (squash) November 15, 2024 09:01
@zbycz zbycz merged commit 48e6eae into master Nov 15, 2024
2 checks passed
@zbycz zbycz deleted the ofr branch November 15, 2024 09:02
@zbycz zbycz mentioned this pull request Nov 15, 2024
@govvin
Copy link

govvin commented Nov 15, 2024

I'm getting this error message when clicking on a feature while the Basic Open Freemap layer is active:
image

When I switch back to Basic, the information about the feature is displayed without any hitches:
image

@zbycz
Copy link
Owner Author

zbycz commented Nov 15, 2024

@govvin - thanks for the report. I see – unfortunately the OpenFreeMap encodes the ids wrong. You can see it in Browser DevTools - of you click a POI, the last number in the id encodes 0=node, 1=way and 4=relation. For you it should end with 0, but in OFR it ends with 1.

Devtools:
image

I created an issue for it here #771 and eventually will contact OFR team on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants