Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emacs keybinding improvements (2025-01-02) #22590

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Emacs keybinding improvements (2025-01-02) #22590

merged 1 commit into from
Jan 3, 2025

Conversation

notpeter
Copy link
Member

@notpeter notpeter commented Jan 2, 2025

Various improvements to the emacs compatibility keybindings.

Release Notes:

  • Improvements to emacs keybindings:
    • Better support for running emacs inside Zed terminal (e.g. ctrl-x ctrl-c will quit emacs in terminal not zed)
    • alt-^ Join Lines
    • ctrl-/ Undo
    • alt-. GotoDefinition and alt-, GoBack
    • ctrl-x h SelectAll
    • alt-< / alt-> Goto End/Beginning of Buffer
    • ctrl-g as Menu::cancel

@notpeter
Emacs keybinding improvements (2025-01-02)
8724f23 
- Add comments with emacs command names
- Move some keybinds from `Workspace` to `Workspace && !Terminal` to better support using emacs in Terminal
- Remove some keybinds which are not used by default in emacs
- Add shortcuts for: toggle comments, goto line, beginning/end of file, case conversion
- More!
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 2, 2025
@zed-industries-bot
Copy link

Messages
📖

This PR includes links to the following GitHub Issues: #4856
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 8724f23

@notpeter notpeter self-assigned this Jan 2, 2025
@notpeter notpeter mentioned this pull request Jan 2, 2025
Merged
@notpeter notpeter added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit e5c3d5d Jan 3, 2025
13 checks passed
@notpeter notpeter deleted the emacs_2025 branch January 3, 2025 17:02
This was referenced Jan 6, 2025
Open
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2025
@notpeter
emacs: Fix using emacs in embedded terminal (#22779)
57dfaa6 
- Follow-up to: #22590

Release Notes:

- N/A
@ryukinix
Copy link

ryukinix commented Jan 9, 2025

Very nice @notpeter

@notpeter notpeter mentioned this pull request Jan 10, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
@notpeter
emacs: Fix emacs in embedded terminal on Linux too (#22969)
3795963 
- Follow-up to #22779 (accidentially did macos only)
- Follow-up to: #22590

Release Notes:

- N/A
notpeter added a commit that referenced this pull request Jan 10, 2025
@notpeter
emacs: Fix emacs in embedded terminal on Linux too (#22969)
a297e19 
- Follow-up to #22779 (accidentially did macos only)
- Follow-up to: #22590

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notpeter notpeter

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notpeter @zed-industries-bot @ryukinix