Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Git Panel UI, continued #22960

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

git: Git Panel UI, continued #22960

wants to merge 25 commits into from

Conversation

iamnbutler
Copy link
Member

@iamnbutler iamnbutler commented Jan 10, 2025

TODO:

  • Investigate incorrect hit target for stage all button
  • Add top level context menu
  • Add entry context menus
  • Show paths in list view
  • For now, enter can just open the file
  • 🐞: Hover deadzone in list caused by scrollbar
  • 🐞: Incorrect status/nothing shown when multiple worktrees are added

This PR continues work on the feature flagged git panel.

Changes:

  • Defines and wires up git panel actions & keybindings
  • Re-scopes some actions from git_ui -> git.
    • General git actions (StageAll, CommitChanges, ...) are scoped to git.
    • Git panel specific actions (Close, FocusCommitEditor, ...) are scoped to `git_panel.
  • Staging actions & UI are now connected to git!
  • Unify more reusable git status into the GitState global over being tied to the panel directly.
  • Uses the new git status codepaths instead of filtering all workspace entries

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 10, 2025
@iamnbutler iamnbutler marked this pull request as ready for review January 10, 2025 16:55
@maxdeviant maxdeviant changed the title git: Git Panel UI Cont. git: Git Panel UI, continued Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants