Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple Spicy doc nits #276

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix a couple Spicy doc nits #276

merged 2 commits into from
Oct 9, 2024

Conversation

evantypanski
Copy link
Contributor

@evantypanski evantypanski commented Oct 9, 2024 •
edited
Loading

  • convenient was misspelled
  • Spicy TFTP example needs another pass, apparently there's another script that is roughly similar that still used get_tag :)
  • Fixed up some whitespace stuff in that TFTP example - that file mixed tabs and 8 spaces so I just moved it to 4 spaces.

Fun fact: building docs fresh was fine, but when I pulled main and rebuilt it, it crashed my laptop and tried to crash it again when I retried. Like 7 python processes each taking 3GB :O

@evantypanski
Fix typo "convinient" -> "convenient"
e495757
@evantypanski
Fix the included Spicy TFTP example style
0f108f6 
- Replace `Analyzer::get_tag` call with `Analyzer::ANALYZER_SPICY_TFTP`
- Remove some spaces at the end of lines
- Retab to use 4 spaces, not tabs
@evantypanski evantypanski requested a review from bbannier October 9, 2024 15:29
bbannier
bbannier approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@bbannier bbannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The CI failures are due to e4f1f2b and not this PR.

@bbannier bbannier merged commit 5f8d71c into master Oct 9, 2024
0 of 10 checks passed
@bbannier bbannier deleted the topic/etyp/spicy-doc-fixes branch October 9, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbannier bbannier bbannier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evantypanski @bbannier