signatures: Support custom event via [event_name] syntax #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelzel
added
the
Docs: required
awelzel
force-pushed
the
topic/awelzel/3403-signature-match-event
branch
from
64d2473 to
67b4214
Compare
awelzel
force-pushed
the
topic/awelzel/3403-signature-match-event
branch
2 times, most recently
from
ad94802 to
8a3caec
Compare
awelzel
force-pushed
the
topic/awelzel/3403-signature-match-event
branch
from
8a3caec to
ff582e0
Compare
timwoj
approved these changes
Dec 4, 2023
vpax
reviewed
Dec 5, 2023
vpax
reviewed
Dec 5, 2023
vpax
reviewed
Dec 5, 2023
vpax
reviewed
Dec 5, 2023
vpax
reviewed
Dec 5, 2023
|
@awelzel looks good, I just have some micro-questions, per what I've now entered above |
When trying to use TOK_IDENT and TOK_STRING in a single rule, that resulted in "corrupt" strings. https://www.gnu.org/software/bison/manual/html_node/Strings-are-Destroyed.html
With custom events for signatures, Reporter::error() may be invoked while loading them. Early exit in case that happens. We could continue and either disable the signatures or fallback to the default signature_match() event, but not sure that would be obviously better.
This change allows to specify a per signature specific event, overriding the default signature_match event. It further removes the message parameter from such events if not provided in the signature. This also tracks the message as StringValPtr directly to avoid allocating the same StringVal for every DoAction() call. Closes #3403
And return const std::string& from GetMIME(). Probably not at all performance relevant, but while I'm already here.
awelzel
force-pushed
the
topic/awelzel/3403-signature-match-event
branch
from
ff582e0 to
e8241e1
Compare
|
@awelzel thanks for the clarifications, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to specify a per signature specific event, overriding
the default signature_match event. It further removes the message
parameter from such events if not provided in the signature.
Closes #3403
zeek-docs: zeek/zeek-docs#234