Update rust toolchain to 1.84 #3945
Conversation
which really should have been deleted as part of zellij-org#2012. This hasn't been updated for more than 2 years now and I don't expect anyone to still use this. Our build process is now managed by `cargo xtask`.
from 1.75.0 which has been deprecated for a while now. Along with this change, the `wasm32-wasi` target is no longer available (see subsequent commit for additional info).
as required by the Rust project. The `wasm32-wasi` target name has been retired and will likely be reused at a later time, although to express an entirely different target (i.e. implementation of the WASI standard). For additional information, see: - https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html - https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#wasi-01-target-naming-changed
from the `rust-toolchain.toml` definition. This was added way back in 2021 via 8688569, and while I'm not sure what it expressed back then, nowadays it refers to [Metadata for RLS][1], which apparently was an early language server implementation and has long since been replaced by *rust-analyzer*. We don't want to propose or enforce the use of a specific toolchain and in any case, setting this up properly is the job of a developers IDE/Editor. [1]: https://github.com/rust-lang/rustup/blob/1f06e3b31d444f3649dd51225a9d38362f7313e0/doc/user-guide/src/concepts/components.md#previous-components
from `std::panic::PanicInfo` to `std::panic::PanicHookInfo`, which was introduced in Rust 1.81.0. For additional information, see: - https://releases.rs/docs/1.81.0/#compatibility-notes - rust-lang/rust#115974
in match arm patterns, since the expression being matched against has been modified using `to_ascii_lowercase`. Hence, we cannot have upper case ASCII chars in the expressions (these arms were previously no-ops).
in `input/layout` since the `PartialEq` trait is also implemented manually. Previously the `Hash` impl wasn't consistent with the `Eq` impl, which can have weird effects when using these types in e.g. `HashMap`s or similar types. For additional information, see: - https://rust-lang.github.io/rust-clippy/master/index.html#derived_hash_with_manual_eq - https://doc.rust-lang.org/stable/std/hash/trait.Hash.html#hash-and-eq
in `pane_size` since the `PartialEq` trait is also implemented manually. Previously the `Hash` impl wasn't consistent with the `Eq` impl, which can have weird effects when using these types in e.g. `HashMap`s or similar types. For additional information, see: - https://rust-lang.github.io/rust-clippy/master/index.html#derived_hash_with_manual_eq - https://doc.rust-lang.org/stable/std/hash/trait.Hash.html#hash-and-eq
with their same names. Latest rust toolchains reject this code.
for the Rust toolchain. The previously used action has been archived over a year ago. The new one should also support reading our `rust-toolchain.toml`, so we no longer have to keep track of the toolchain in multiple places.
to make them better visually parsable.
since as far as I can tell, this isn't used any more.
and only request an action without running other code.
|
So the CI passes alright and @tlinford I hope it's okay if I ping you: Iirc you've got a Mac lying around somewhere. Could you try to run the built binary off this branch on Mac just to make sure I'm not upsetting apple users with this change? |
Yes, no worries. Gave it a quick smoke test, compiled and ran fine. |
|
Thanks for the feedback @tlinford! In the meantime I got the simulated releases to work with Rust 1.84 and the binaries I built/released from this branch compile and run fine (as far as I could determine). The new rust version seems to also introduce a bunch of build-time warnings into @imsnif This PR touches CI stuff (also for the release pipeline) so I'll stick around during the next release. |
|
@bjorn3 I saw your comment over in bytecodealliance/wasmtime#10074, so I thought I'd let you know the toolchain has been updated now. :) |
|
Thanks. Opened #3955. |
Updates the Rust toolchain from 1.75.0 (which is deprecated) to 1.84.0 (which is the latest stable version at the time of this writing).
This update covers quite a few toolchain version changes and necessitates a few changes in our code. See below (or the commits in this PR) for additional information.
I'll keep this open until I'm certain the change doesn't break the application. Most notably I currently get an error in the snapshot tests and I haven't ran a simulated release yet.
Once all of these pass, I'll merge this change.
Update the
wasm32-wasitarget towasm32-wasip1The
wasm32-wasitarget has triggered compiler-warnings since 1.81.0 and has been fully removed in January 2025. It has been renamed towasm32-wasip1so that's what we're also using now.The target has been renamed appropriately in all locations where it was previously used, this includes (afaict):
Other breaking changes
PanicInfotype has been renamed toPanicHookInfo(260be7f)Other non-breaking changes
rust-analysistoolchain component any longer (b2c86dd)Makefile.toml(29d8750)