Lint Ruby with StandardRb #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the linter with either - `bundle exec rake standard`, or - `bundle exec standardrb`
bquorning
force-pushed
the
bquorning/standard
branch
from
97ba53a to
c359a53
Compare
HeyNonster
approved these changes
Nov 8, 2023
With the old configuration, we would run CI twice when pushing a commit and opening a pull request. Or when pushing a commit that belongs to a pull request. With the new configuration, we run CI once when opening a PR, and once when pushing a commit that belongs to a pull request. And once when merging to master (the `push` event). Importantly, this configuration still works for contributions from forked repositories, since the `pull_request` events are triggered on _our_ fork. Also adding the .git-blame-ignore-revs file matching the recent "style change commits".
bquorning
force-pushed
the
bquorning/standard
branch
from
c359a53 to
e17bd18
Compare
HeyNonster
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let’s put some code standards on this project.