Upgrade Great Expectations integration to 1.0.4 #3025

wjayesh · 2024-09-18T15:07:49Z

Describe changes

I upgraded great expectations to 1.0.4.

Data Profiling is no longer supported since profiles have been moved out of Great Expectations open-source.
Data Validation is amended to now take in a list of Expectations directly from the user, or an Expectation Suite that the user has already created.
There's a new class to help users define their Expectations and expectation arguments.
The materializer is updated to better support the updated CheckpointResult object.
Checkpoints now take in a validation definition which is built with a batch definition and expectation suite. More here.

Testing

This has only been tested with a subset of Expectations on an ephemeral storage so far. Some more tests need to happen and will be done incrementally.

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

coderabbitai · 2024-09-18T15:07:58Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

bcdurak

The PR needs a round of formatting and linting. Also, it would be really nice to conduct some tests and update the current test that we have.

docs/book/component-guide/data-validators/great-expectations.md

src/zenml/integrations/great_expectations/steps/ge_validator.py

src/zenml/integrations/great_expectations/materializers/ge_materializer.py

src/zenml/integrations/great_expectations/data_validators/expectations.py

bcdurak · 2024-09-23T13:49:27Z

src/zenml/integrations/great_expectations/data_validators/expectations.py

+    @staticmethod
+    def get_expectation_class(expectation_name: str) -> Type[Expectation]:
+        """Get the Great Expectation expectation class associated with this config.
+


Missing Args in the docstring.

Also excess Raises.

it does raise a TypeError as i dont catch the one coming from the load_and_validate_class function

src/zenml/integrations/great_expectations/data_validators/ge_data_validator.py

src/zenml/integrations/great_expectations/data_validators/expectations.py

src/zenml/integrations/great_expectations/materializers/ge_materializer.py

Co-authored-by: Barış Can Durak <[email protected]>

github-actions · 2024-09-26T04:10:48Z

Classification template updates in examples/mlops_starter have been pushed.

review-notebook-app · 2024-09-26T04:10:53Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions · 2024-09-26T04:20:06Z

NLP template updates in examples/e2e_nlp have been pushed.

…nml-io/zenml into growthhack1/greatexpectations

hyperlint-ai

1 files reviewed, 1 total issue(s) found.

Note: We resolved prior Hyperlint review comments because:

We updated our inline suggestion AI.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

docs/book/component-guide/data-validators/great-expectations.md

hyperlint-ai

1 files reviewed, 1 total issue(s) found.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

[Vv]alidator

hyperlint-ai · 2024-10-04T06:35:49Z

docs/book/component-guide/data-validators/great-expectations.md

 )
 ```

-The step can then be inserted into your pipeline where it can take in a pandas dataframe and a bool flag used solely for order reinforcement purposes, e.g.:
+The step can then be inserted into your pipeline where it can take in a pandas dataframe e.g.:


Suggested change

The step can then be inserted into your pipeline where it can take in a pandas dataframe e.g.:

The step can then be inserted into your pipeline where it can take in a pandas DataFrame e.g.:

Issues:

Style Guide - (Spelling-error) Did you really mean 'dataframe'?

Fix Explanation:

The correct spelling for the pandas object is 'DataFrame'. This aligns with the official pandas documentation and ensures consistency and accuracy in technical writing.

wjayesh added 8 commits September 4, 2024 21:50

define config class for expectations

c5766c1

update great expectation implementation

830e1c2

fix materializer

e4f2d95

return datasource name

38fbabe

fix ds deltion

2fbdd83

all the fixes except for the materializer

f4ef8a3

fix materializer

596fdc3

update version

cf0514c

github-actions bot added the internal To filter out internal PRs and issues label Sep 18, 2024

htahir1 requested a review from bcdurak September 19, 2024 12:27

update docs

c6efb56

bcdurak requested changes Sep 23, 2024

View reviewed changes

wjayesh and others added 3 commits September 26, 2024 09:37

Update docs/book/component-guide/data-validators/great-expectations.md

9029f14

Co-authored-by: Barış Can Durak <[email protected]>

Update src/zenml/integrations/great_expectations/steps/ge_validator.py

83dc040

Co-authored-by: Barış Can Durak <[email protected]>

Auto-update of Starter template

c732267

Auto-update of NLP template

e944fdf

wjayesh added 4 commits September 26, 2024 10:04

apply review changes

38f2ca7

Merge branch 'growthhack1/greatexpectations' of https://github.com/ze…

3b8b87d

…nml-io/zenml into growthhack1/greatexpectations

add libs to mocked libs

19ad36b

simplify materializer logic

14a1711

hyperlint-ai bot reviewed Oct 3, 2024

View reviewed changes

docs/book/component-guide/data-validators/great-expectations.md Show resolved Hide resolved

dont delete datasource and fix materializer

4bc0632

hyperlint-ai bot reviewed Oct 4, 2024

View reviewed changes

wjayesh added 3 commits October 4, 2024 12:25

fix loading logic

8ee1646

add validation def store

237fa41

set project on context call

fdaa83a

fix validation ident tuple

1bdafc9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Great Expectations integration to 1.0.4 #3025

Upgrade Great Expectations integration to 1.0.4 #3025

wjayesh commented Sep 18, 2024 •

edited

Loading

coderabbitai bot commented Sep 18, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

bcdurak left a comment

bcdurak Sep 23, 2024

bcdurak Sep 23, 2024

wjayesh Sep 26, 2024

github-actions bot commented Sep 26, 2024

review-notebook-app bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

hyperlint-ai bot left a comment •

edited

Loading

hyperlint-ai bot left a comment

hyperlint-ai bot Oct 4, 2024

	The step can then be inserted into your pipeline where it can take in a pandas dataframe e.g.:
	The step can then be inserted into your pipeline where it can take in a pandas DataFrame e.g.:

Upgrade Great Expectations integration to 1.0.4 #3025

Are you sure you want to change the base?

Upgrade Great Expectations integration to 1.0.4 #3025

Conversation

wjayesh commented Sep 18, 2024 • edited Loading

Describe changes

Testing

Pre-requisites

Types of changes

coderabbitai bot commented Sep 18, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

bcdurak left a comment

Choose a reason for hiding this comment

bcdurak Sep 23, 2024

Choose a reason for hiding this comment

bcdurak Sep 23, 2024

Choose a reason for hiding this comment

wjayesh Sep 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 26, 2024

review-notebook-app bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

hyperlint-ai bot left a comment • edited Loading

Choose a reason for hiding this comment

hyperlint-ai bot left a comment

Choose a reason for hiding this comment

hyperlint-ai bot Oct 4, 2024

Choose a reason for hiding this comment

wjayesh commented Sep 18, 2024 •

edited

Loading

coderabbitai bot commented Sep 18, 2024 •

edited

Loading

hyperlint-ai bot left a comment •

edited

Loading