-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: expand performance testing to catch errors, fixed connection refused errors, added performance testing with state. #2400
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11033143 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/local/accounts.go | View secret |
11033143 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/config/localnet.yml | View secret |
11033143 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/config/local.yml | View secret |
11033144 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/local/accounts.go | View secret |
11033144 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/config/localnet.yml | View secret |
11033145 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/config/localnet.yml | View secret |
11033145 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/local/accounts.go | View secret |
11033146 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/config/localnet.yml | View secret |
11033146 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/local/accounts.go | View secret |
11478175 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/config/localnet.yml | View secret |
11478176 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/config/localnet.yml | View secret |
11759679 | Triggered | Generic High Entropy Secret | fa72824 | cmd/zetae2e/local/accounts.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (3)
You can disable this status message by setting the Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is one comment leftover from your testing but other than that it looks good.
Description
How Has This Been Tested?
I executed multiple Github Action scenarios to ensure all logic functioned as intended through failure and success scenarios.
Failed Test: https://github.com/zeta-chain/node/actions/runs/9719615016
Failed Test w/State: https://github.com/zeta-chain/node/actions/runs/9719839293
Success Test: https://github.com/zeta-chain/node/actions/runs/9719810694
Success Tests With State: https://github.com/zeta-chain/node/actions/runs/9719842212/job/26830323773