Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: expand performance testing to catch errors, fixed connection refused errors, added performance testing with state. #2400

Merged
merged 45 commits into from
Jul 1, 2024

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Jun 29, 2024

Description

  1. Expanded the logic the pipeline to look for errors in the report json if no failures we're reported via artillery as a secondary check to ensure we know when tests fail/succeed.
  2. Fixed connection refused errors. These errors we're happening locally. The issue is using the composite for artillery uses docker backed composite so the network was separate. The reports weren't clear that it was failing or if it was reporting wrong. That is corrected now.
  3. Added starting a local net from the state export to performance test with state.
  4. Added slack channel notification when testing fails so the DevOps team can know about it when it happens.

How Has This Been Tested?

I executed multiple Github Action scenarios to ensure all logic functioned as intended through failure and success scenarios.

Failed Test: https://github.com/zeta-chain/node/actions/runs/9719615016
Failed Test w/State: https://github.com/zeta-chain/node/actions/runs/9719839293
Success Test: https://github.com/zeta-chain/node/actions/runs/9719810694
Success Tests With State: https://github.com/zeta-chain/node/actions/runs/9719842212/job/26830323773

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

@gzukel gzukel requested a review from a team as a code owner June 29, 2024 00:19
Copy link

gitguardian bot commented Jun 29, 2024

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11033143 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/local/accounts.go View secret
11033143 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/config/localnet.yml View secret
11033143 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/config/local.yml View secret
11033144 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/local/accounts.go View secret
11033144 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/config/localnet.yml View secret
11033145 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/config/localnet.yml View secret
11033145 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/local/accounts.go View secret
11033146 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/config/localnet.yml View secret
11033146 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/local/accounts.go View secret
11478175 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/config/localnet.yml View secret
11478176 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/config/localnet.yml View secret
11759679 Triggered Generic High Entropy Secret fa72824 cmd/zetae2e/local/accounts.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

coderabbitai bot commented Jun 29, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (3)
  • .github/actions/performance-tests/art.yaml is excluded by none and included by none
  • .github/workflows/ci-nightly-performance-testing.yaml is excluded by none and included by none
  • changelog.md is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Jun 29, 2024
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@CharlieMc0 CharlieMc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one comment leftover from your testing but other than that it looks good.

.github/actions/performance-tests/art.yaml Outdated Show resolved Hide resolved
@gzukel gzukel requested a review from CharlieMc0 July 1, 2024 00:03
@gzukel gzukel requested a review from fbac as a code owner July 1, 2024 21:31
@gzukel gzukel requested a review from gartnera July 1, 2024 22:25
@gzukel gzukel merged commit ba6bc6f into develop Jul 1, 2024
18 of 19 checks passed
@gzukel gzukel deleted the ci-fix-performance-testing branch July 1, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants