refactor(e2e): add functions for funding zevm accounts instart-zetae2e.sh

[swift1337]

TLDR

# unlock v2 ethers revert tests accounts
fund_zevm_from_config '.additional_accounts.user_v2_ether_revert.evm_address' 10000 "V2 ethers revert tester"

instead of

address=$(yq -r '.default_account.evm_address' config.yml)
echo "funding deployer address ${address} with 10000 Ether"
geth --exec "eth.sendTransaction({from: eth.coinbase, to: '${address}', value: web3.toWei(10000,'ether')})" attach http://eth:8545 > /dev/null

New aliases:

• fund_zevm_from_config
• fund_zevm
• config_str

Summary by CodeRabbit

• New Features

  • Enhanced funding process for accounts on ZetaChain, streamlining the retrieval of configuration data and funding transactions.
  • Introduced new functions to simplify and improve the efficiency of the funding script.

• Improvements

  • Simplified control flow in the funding script, reducing redundancy and minimizing the risk of errors.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Walkthrough

The changes introduce two new functions, config_str and fund_zevm_from_config, to the start-zetae2e.sh script. These functions enhance the process of retrieving configuration data and funding accounts on the ZetaChain. The modifications streamline the script by reducing redundancy in address retrieval and funding transactions, simplifying the control flow, and improving the overall maintainability of the script.

Changes

File Path	Change Summary
contrib/localnet/orchestrator/start-zetae2e.sh	Added config_str() and fund_zevm_from_config() functions to streamline address retrieval and funding processes. Reduced redundancy in the script by encapsulating logic for multiple accounts.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f617c89 and da096b0.

Files selected for processing (1)

• contrib/localnet/orchestrator/start-zetae2e.sh (3 hunks)

Additional context used

Path-based instructions (1)

contrib/localnet/orchestrator/start-zetae2e.sh (1)

Pattern **/*.sh: Review the shell scripts, point out issues relative to security, performance, and maintainability.

Additional comments not posted (2)

contrib/localnet/orchestrator/start-zetae2e.sh (2)

31-33: LGTM!

The config_str function is a useful addition to the script. It encapsulates the logic for reading configuration values from the config.yml file using the yq command. The function is well-documented, follows the naming convention, and provides a clear usage example.

---

55-70: LGTM!

The fund_zevm_from_config function is a valuable addition to the script. It combines the functionality of config_str and fund_zevm functions to provide a convenient way to fund ZetaChain addresses retrieved from the configuration file. The function is well-documented, follows the naming convention, and includes error handling for missing addresses.

By encapsulating the address retrieval and funding logic, the function enhances the script's maintainability and reduces code duplication. It provides a higher-level abstraction that makes the script more readable and easier to understand.

[lumtis]

Can we use a more descriptive name for the PR?