Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/agent error handling #277

Merged
merged 6 commits into from
Jan 14, 2025
Merged

F/agent error handling #277

merged 6 commits into from
Jan 14, 2025
+5 −6

Conversation

jmagoon
Copy link
Member

@jmagoon jmagoon commented Jan 9, 2025

  • handles errors when we try to run openai models that the user doesn't have access to
  • handles generic errors emitted from python script call
  • adds more generalized error handling framework

@jmagoon jmagoon requested a review from FGRCL January 9, 2025 01:27
FGRCL
FGRCL reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@FGRCL FGRCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I'm not sure if I did something wrong, but the full message didn't show up when I tried it

frontend/src/hooks/useCompileSpecs.jsx Outdated Show resolved Hide resolved
frontend/src/components/ui/blockEditor/directoryViewer/AgentPrompt.jsx Outdated Show resolved Hide resolved
frontend/src/components/ui/blockEditor/directoryViewer/AgentPrompt.jsx Outdated Show resolved Hide resolved
frontend/src/components/ui/blockEditor/directoryViewer/AgentPrompt.jsx Outdated Show resolved Hide resolved
frontend/eslint.config.js Outdated Show resolved Hide resolved
frontend/server/blockSerialization.ts Outdated Show resolved Hide resolved
frontend/server/blockSerialization.ts Outdated Show resolved Hide resolved
frontend/server/blockSerialization.ts Outdated Show resolved Hide resolved
frontend/agents/gpt-4_python_compute/generate/computations.py Outdated Show resolved Hide resolved
frontend/agents/gpt-4_python_compute/generate/computations.py Outdated Show resolved Hide resolved
@jmagoon
Copy link
Member Author

jmagoon commented Jan 13, 2025

image I'm not sure if I did something wrong, but the full message didn't show up when I tried it

Yeah it's a CSS issue. I tried hard to get the full error to show but it's getting cut off by the toast. IMO it's ok as the next improvement before needing to do a larger overhaul of different error classes.

@amansingh0330 amansingh0330 merged commit 7a14fc3 into main Jan 14, 2025
8 checks passed
@amansingh0330 amansingh0330 deleted the f/agent-error-handling branch January 14, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FGRCL FGRCL FGRCL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagoon @FGRCL @amansingh0330