Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build option to disable C++ exceptions #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-day-old-bagel
Copy link
Member

@a-day-old-bagel a-day-old-bagel commented Jan 9, 2025

I was able to get zphysics building together with zgpu on Windows again by disabling C++ exceptions.

If we can merge this, we might be able to turn on those two samples that stopped working in Windows.

@a-day-old-bagel
Copy link
Member Author

a-day-old-bagel commented Jan 9, 2025

Since I'm used to the old monorepo, this is a bit confusing, but I surmise that if we merge this, the next step would be to update the monorepo to point to the new commit here, and then, at that point, update monolith and physics_test_wgpu to turn on this no_exceptions option.

I believe this is enough to resolve the duplicate definition issue, since it has appeared to fix it for my own project. However, it might be necessary to also disable exceptions for other 3rd party C++ libraries too in some cases.

So once this is merged, I can fix those and make a PR on the monorepo too if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant