Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return ax from scatter for external usage #253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

return ax from scatter for external usage #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b763e8
return ax from scatter for external usage
PythonFZ Jan 4, 2024
7c13107
Merge branch 'main' into return_ax
PythonFZ Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ipsuite/analysis/model/plots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def density_scatter(ax, x, y, bins, **kwargs) -> None:
# Sort the points by density, so that the densest points are plotted last
idx = z.argsort()
x, y, z = x[idx], y[idx], z[idx]
ax.scatter(x, y, c=z, **kwargs)
return ax.scatter(x, y, c=z, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this return ax itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I need this change, but I found another solution. There is probably a better way to make this function more user friendly, but we can also close.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind either way



def get_figure(
Expand Down
Loading