PR Change: 'ZIO-succeed' -> 'Exit.succeed' for non-effectful completi…

…on of onFailure promise.
zio · Jan 2, 2025 · 451499d · 451499d
1 parent e080d81
commit 451499d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/zio-http/jvm/src/main/scala/zio/http/netty/WebSocketAppHandler.scala b/zio-http/jvm/src/main/scala/zio/http/netty/WebSocketAppHandler.scala
@@ -69,7 +69,7 @@ private[zio] final class WebSocketAppHandler(
     callbacks match {
       case Some((onComplete, onFailure)) =>
         onComplete.unsafe.done(Exit.fail(cause))
-        onFailure.unsafe.done(ZIO.succeed(cause))
+        onFailure.unsafe.done(Exit.succeed(cause))
       case None                          => ()
     }
   }

diff --git a/zio-http/jvm/src/main/scala/zio/http/netty/client/ClientFailureHandler.scala b/zio-http/jvm/src/main/scala/zio/http/netty/client/ClientFailureHandler.scala
@@ -1,6 +1,6 @@
 package zio.http.netty.client
 
-import zio.{Exit, Promise, Unsafe, ZIO}
+import zio.{Exit, Promise, Unsafe}
 
 import zio.http.Response
 import zio.http.internal.ChannelState
@@ -19,6 +19,6 @@ private[netty] final class ClientFailureHandler(
     val exit = Exit.fail(cause)
     onResponse.unsafe.done(exit)
     onComplete.unsafe.done(exit)
-    onFailure.unsafe.done(ZIO.succeed(cause))
+    onFailure.unsafe.done(Exit.succeed(cause))
   }
 }
diff --git a/zio-http/jvm/src/main/scala/zio/http/netty/client/WebSocketClientInboundHandler.scala b/zio-http/jvm/src/main/scala/zio/http/netty/client/WebSocketClientInboundHandler.scala
@@ -42,10 +42,9 @@ private[netty] final class WebSocketClientInboundHandler(
   }
 
   override def exceptionCaught(ctx: ChannelHandlerContext, error: Throwable): Unit = {
-    implicit val trace = Trace.empty
-    val exit           = Exit.fail(error)
+    val exit = Exit.fail(error)
     onResponse.unsafe.done(exit)
     onComplete.unsafe.done(exit)
-    onFailure.unsafe.done(ZIO.succeed(error))
+    onFailure.unsafe.done(Exit.succeed(error))
   }
 }