Make Endpoint respond with a 401 status code if the Authorization header is missing #3281
+36
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notxcain
commented
Jan 22, 2025
| @@ -340,9 +340,10 @@ final case class Endpoint[PathInput, Input, Err, Output, Auth <: AuthType]( | |||
| case Some(HttpCodecError.CustomError("SchemaTransformationFailure", message)) | |||
| if maybeUnauthedResponse.isDefined && message.endsWith(" auth required") => | |||
| maybeUnauthedResponse.get | |||
| case Some(_) => | |||
| case Some(HttpCodecError.MissingAuthorizationHeader) => | |||
| Handler.succeed(Response.unauthorized) | |||
There was a problem hiding this comment.
Let me know if this should be reported the same way is any other missing header.
| case Some(_) => | ||
| case Some(HttpCodecError.MissingAuthorizationHeader) => | ||
| Handler.succeed(Response.unauthorized) | ||
| case Some(error) => |
There was a problem hiding this comment.
Not sure why it was not written this way, as it looks like in this case asHttpCodecError provides the same value as cause.defects.head.asInstanceOf[HttpCodecError].
notxcain
commented
Jan 22, 2025
| @@ -33,6 +33,9 @@ object HttpCodecError { | |||
| final case class MissingHeader(headerName: String) extends HttpCodecError { | |||
| def message = s"Missing header $headerName" | |||
| } | |||
| final case object MissingAuthorizationHeader extends HttpCodecError { | |||
There was a problem hiding this comment.
I believe introducing a special case for that purpose helps with reasoning. Let me know if you'd like this to be implement using MissingHeader.
notxcain
requested review from
jdegoes,
vigoo,
kyri-petrou and
987Nabil
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #3235