Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secp256k1 #413

Merged
merged 16 commits into from
Dec 24, 2024
Merged

Secp256k1 #413

merged 16 commits into from
Dec 24, 2024

Conversation

echatav
Copy link
Contributor

@echatav echatav commented Dec 18, 2024 •
edited
Loading

@echatav echatav marked this pull request as ready for review December 18, 2024 19:22
@echatav echatav added the ready for review needs review before merge label Dec 18, 2024
@vlasin vlasin requested review from TurtlePU and vlasin December 19, 2024 10:34
@vlasin
Copy link
Contributor

vlasin commented Dec 23, 2024

The build is failing after the merge. Also, @TurtlePU, please review.

TurtlePU
TurtlePU previously approved these changes Dec 23, 2024
View reviewed changes
@TurtlePU
Copy link
Contributor

LGTM! Only build errors have to be fixed

@echatav echatav requested a review from TurtlePU December 23, 2024 15:55
@vlasin vlasin merged commit fb9b9c4 into main Dec 24, 2024
1 check passed
@vlasin vlasin deleted the eitan-ec-secp256k1 branch December 24, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurtlePU TurtlePU TurtlePU approved these changes

@vlasin vlasin Awaiting requested review from vlasin

Assignees
No one assigned
Labels
ready for review needs review before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Secp256k1 curve
3 participants
@echatav @vlasin @TurtlePU