Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Refactor survey task editor thumbnail input per FEM or PFE lab #7246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Jan 13, 2025

Staging branch URL: https://pr-7246.pfe-preview.zooniverse.org

Technically different solution, but addresses and closes #7168 .
I think supersedes #7184 .

IMPORTANT❗ - related to and should be deployed to production with zooniverse/front-end-monorepo/pull/6574

Describe your changes.

  • use isThisProjectUsingFEMLab to conditionally display survey task thumbnail inputs
  • if PFE lab / PFE project then render legacy/old thumbnail section
  • if FEM lab / FEM project then render new thumbnail section with only "show" and "hide"

Testing links

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@coveralls
Copy link

Coverage Status

coverage: 56.628% (-0.1%) from 56.77%
when pulling 08f2b3b on femLab_survey-task-thumbnails
into 9d723fb on master.

@mcbouslog
Copy link
Contributor Author

With these changes, if a current PFE project adds ?femLab=true then the survey task editor thumbnail section will appear to have "show" selected and if previewed in FEM thumbnails will show, but the thumbnails task property will remain set to "default" until it's actually changed to "hide" or "show". This is intentional, so if the project doesn't go to FEM, no workflow task thumbnail property change is made.

@mcbouslog mcbouslog requested a review from a team January 13, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Survey task: lab options regarding thumbnails
2 participants