PR changes.

zooniverse · Jan 21, 2025 · 7f21ee7 · 7f21ee7
1 parent 6e27463
commit 7f21ee7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/...lassifier/components/SubjectViewer/components/VolumetricViewer/VolumetricViewerWrapper.js b/...lassifier/components/SubjectViewer/components/VolumetricViewer/VolumetricViewerWrapper.js
@@ -22,7 +22,6 @@ function VolumetricViewerWrapper({
   }
 
   const config = {
-    annotations: [],
     loadingState,
     onAnnotation: onAnnotationUpdate,
     onError,

diff --git a/packages/lib-subject-viewers/src/VolumetricViewer/README.md b/packages/lib-subject-viewers/src/VolumetricViewer/README.md
@@ -5,4 +5,4 @@ This directory holds all the relevant code for rendering the VolumetricViewer. T
 - `VolumetricViewerComponent` - a React component for the VolumetricViewer
 - `VolumetricViewerData` - a function that returns the data with instantiated models along with the React Component
 
-NOTE: Webpack has trouble importing from a node_module package from dependent package chains (`lib-subject-viewers` => `lib-classifier` => `app-project`), therefore we have inlined `OrbitControls.js` file so that it works without Webpack issues. When updating the `three` dependency in `package.json` make sure to copy the file from `node_modules/three/examples/jsm/controls/OrbitControls.js` to `lib-subject-viewers/src/VolumetricViewer/helpers/OrbitControls.js`.
+NOTE: OrbitControls are typically imported as `import { OrbitControls } from 'three/examples/jsm/controls/OrbitControls'` but that syntax throws an error due to FEM not being pure ESM, therefore we have inlined `OrbitControls.js` file so that it works without bundling issues. When updating the `three` dependency in `package.json` make sure to copy the file from `node_modules/three/examples/jsm/controls/OrbitControls.js` to `lib-subject-viewers/src/VolumetricViewer/helpers/OrbitControls.js`.