fix(lib-classifier): work-in-progress warning for new text subjects

The text-from-subject task warns about work-in-progress for every subject. This fixes that by setting the annotation value without marking the annotation as in-progress.
zooniverse · Jan 12, 2025 · b0244ca · b0244ca
1 parent 87ddcb4
commit b0244ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...sifier/src/plugins/tasks/experimental/textFromSubject/models/TextFromSubjectAnnotation.js b/...sifier/src/plugins/tasks/experimental/textFromSubject/models/TextFromSubjectAnnotation.js
@@ -19,7 +19,7 @@ const TextFromSubject = types
     return {
       updateFromSubject (value) {
         self.initializedFromSubject = true
-        self.update(value)
+        self.value = value
       }
     }
   })

diff --git a/...r/src/plugins/tasks/experimental/textFromSubject/models/TextFromSubjectAnnotation.spec.js b/...r/src/plugins/tasks/experimental/textFromSubject/models/TextFromSubjectAnnotation.spec.js
@@ -87,6 +87,10 @@ describe('Model > TextFromSubjectAnnotation', function () {
     it('should have initializedFromSubject of true', function () {
       expect(textFromSubjectAnnotation.initializedFromSubject).to.be.true()
     })
+
+    it('should not be marked as modified', function () {
+      expect(textFromSubjectAnnotation._inProgress).to.be.false()
+    })
   })
 
   describe('with initial update from subject content and valid update from user', function () {