fix(a11y): user select menu labels #6602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatyourgreens
force-pushed
the
user-select-labels
branch
from
34f6999 to
d2934d3
Compare
eatyourgreens
commented
Jan 8, 2025
| @@ -37,15 +37,15 @@ describe('components > shared > MainContent', function () { | |||
|
|
|||
| it('should show "ALL PROJECTS" as the selected project', function () { | |||
| render(<DefaultStory />) | |||
| const projectSelect = screen.getByRole('textbox', { name: 'project-select' }) | |||
| const projectSelect = screen.getByRole('textbox', { name: 'Select project, ALL PROJECTS' }) | |||
There was a problem hiding this comment.
Grommet appends the selected value to the name of the textbox. I'm not sure why, since it will also be read out as the textbox value. 🤷♂️
eatyourgreens
force-pushed
the
user-select-labels
branch
from
d2934d3 to
ec6b2ea
Compare
eatyourgreens
force-pushed
the
user-select-labels
branch
from
ec6b2ea to
3899801
Compare
eatyourgreens
force-pushed
the
user-select-labels
branch
2 times, most recently
from
ae468c7 to
a335298
Compare
eatyourgreens
force-pushed
the
user-select-labels
branch
from
a335298 to
3e18257
Compare
- fix 'Selected: [object Object]' in the labels for user dropdown menus. - add plain English labels for the project and date range menus.
eatyourgreens
force-pushed
the
user-select-labels
branch
from
5215d8a to
2f290ed
Compare
mcbouslog
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Confirmed locally with VoiceOver, changes look good to me, thank you @eatyourgreens ! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please request review from
@zooniverse/frontendteam or an individual member of that team.Package
Linked Issue and/or Talk Post
How to Review
The dropdown menus on the user stats page should have accessible names now, including the selected option.
The group stats visibility menu should also have a plain English name, reflecting the selected option, in the tests and in the storybook.
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrapordocker-compose up --buildand FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Bug Fix