Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.27.0 release notes #128

Merged
merged 2 commits into from
Jan 16, 2025
Merged

0.27.0 release notes #128

merged 2 commits into from
Jan 16, 2025

Conversation

Gallaecio
Copy link
Contributor

@kmike Should we add the pipeline to the add-on, now that it supports nested items, or should we keep it off?

@Gallaecio Gallaecio requested review from kmike and wRAR January 14, 2025 17:21
@wRAR
Copy link
Member

wRAR commented Jan 14, 2025

(good question)

kmike
kmike approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@kmike kmike left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine to not enable DropLowProbability pipeline in the addon. I'm still worried a bit about the default of dropping items with probability < 0.1; it feels like something which should be done by the user explicitly.

@Gallaecio Gallaecio merged commit e329c56 into zytedata:main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

@kmike kmike kmike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gallaecio @wRAR @kmike