Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _get_metadata_class to work recursively #51

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Jul 25, 2023

A straightforward fix for #49 (at least assuming I've implemented BFS correctly), but I don't have a clear picture on what do __orig_bases__ and __origin__ do yet. Note that __mro__ isn't suitable as it's depth-first.

zyte_common_items/pages.py Outdated Show resolved Hide resolved
@wRAR
Copy link
Member Author

wRAR commented Jul 31, 2023

Requires new web-poet (scrapinghub/web-poet#184)

setup.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #51 (bbdf100) into main (a3eb9b6) will not change coverage.
The diff coverage is 0.00%.

❗ Current head bbdf100 differs from pull request most recent head 9eb2e6c. Consider uploading reports for the commit 9eb2e6c to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #51   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          8       8           
  Lines        731     729    -2     
=====================================
+ Misses       731     729    -2     
Files Changed Coverage Δ
zyte_common_items/pages.py 0.00% <0.00%> (ø)

@kmike kmike merged commit 1579eb4 into main Aug 3, 2023
@kmike
Copy link
Contributor

kmike commented Aug 3, 2023

Thanks @wRAR!

@wRAR wRAR deleted the metadata-inheritance branch April 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants