Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serp #98

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Add Serp #98

merged 4 commits into from
Sep 4, 2024

Conversation

Gallaecio
Copy link
Contributor

No description provided.

Copy link
Contributor

@BurnzZ BurnzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VMRuiz
Copy link
Contributor

VMRuiz commented Aug 19, 2024

The fields that defined so far looks good. However, some other important fields like subtitlet, or media type - videos, images - are missing. Are you implementing only the essential fields at this point and leaving the rest of future revisions?

docs/reference/items.rst Outdated Show resolved Hide resolved
@kmike kmike merged commit f93ab09 into zytedata:main Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants