Executor block by block #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mandrigin
reviewed
Aug 2, 2024
hexoscott
reviewed
Aug 5, 2024
There was a problem hiding this comment.
really nice and clean. Great work on chopping out a lot of the cruft from the original WIP branch and moving logic back into the legacy executor verifier code, far cleaner and makes a lot more sense having it there anyway.
I've left some comments for some bits that I didn't quite follow to open up the discussion. The part on handling the l1 info tree during unwinds is a hot one that we definitely want to nail down before merging, happy to help there if needed.
hexoscott
requested changes
Aug 5, 2024
* l1infotree - highest seen + tiny refactor * l1infotreeindexprogress * remove useless param * update how l1infotreeindexprogress is stored
hexoscott
requested changes
Aug 6, 2024
|
hexoscott
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.