Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LDFLAGS to goreleaser to include in the binary the right, version #2713

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Oct 26, 2023

…. Also add a new tag test* to be able to test this solution

Closes #2607
Closes #2719

What does this PR do?

  • Set the right version of releases binaries
  • Allow releases with patch version >9
  • Generate testnet.zip

Reviewers

Main reviewers:

@arnaubennassar

…. Also add a new tag test* to be able to test this solution
@cla-bot cla-bot bot added the cla-signed label Oct 26, 2023
@joanestebanr joanestebanr self-assigned this Oct 26, 2023
@joanestebanr joanestebanr added this to the v0.4.0 milestone Oct 26, 2023
@joanestebanr joanestebanr merged commit eea3365 into develop Oct 26, 2023
18 of 19 checks passed
@joanestebanr joanestebanr deleted the feature/2607-github_releases_binaries_report_incorrect_versions branch October 26, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants