Remove multi-threaded account seed generation #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Jan 15, 2025
PhilippGackstatter
deleted the
pgackst-single-threaded-seed-generation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the multi-threaded account seed generation which appears to be slower than the single-threaded one according to the benchmark in #1056.
Adds pprof profiler for the benchmarks to produce flamegraphs. I thought this might give some insight into where the difference between single- and multi-threaded seed generation comes, but iiuc this "on-cpu" flamegraph doesn't show context switching (as described in https://www.brendangregg.com/FlameGraphs/offcpuflamegraphs.html) and I did not go further down that rabbithole. I left the flamegraph code anyway in case it may be useful in the future, though if we don't want it I can also remove it.
closes #1056