Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi-threaded account seed generation #1061

Merged
merged 5 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
- Introduced `AccountComponentTemplate` with TOML serialization and templating (#1015, #1027).
- Introduce `AccountIdError` and make account ID byte representations (`u128`, `[u8; 15]`) consistent (#1055).
- Refactor `AccountId` and `AccountIdPrefix` into version wrappers (#1058).
- Remove multi-threaded account seed generation due to single-threaded generation being faster (#1061).

## 0.6.2 (2024-11-20)

Expand Down
200 changes: 199 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bin/tx-prover/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ async = ["miden-tx/async"]
default = ["std"]
std = ["miden-objects/std", "miden-tx/std", "dep:tokio", "dep:tonic-web", "dep:tokio-stream", "dep:axum", "dep:tracing", "dep:tracing-subscriber", "tonic/transport"]
testing = ["miden-objects/testing", "miden-lib/testing", "miden-tx/testing"]
concurrent = ["miden-lib/concurrent", "miden-objects/concurrent", "miden-tx/concurrent", "std"]
concurrent = ["miden-tx/concurrent", "std"]

[target.'cfg(all(target_arch = "wasm32", target_os = "unknown"))'.dependencies]
tonic-web-wasm-client = { version = "0.6", default-features = false }
Expand Down
2 changes: 0 additions & 2 deletions miden-lib/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,8 @@ edition.workspace = true
[lib]

[features]
concurrent = ["miden-objects/concurrent", "std"]
default = ["std"]
std = ["assembly/std", "miden-objects/std", "miden-stdlib/std", "vm-processor/std"]
# the testing feature is required to enable the account creation pow patch
testing = ["miden-objects/testing"]
with-debug-info = ["miden-stdlib/with-debug-info"]

Expand Down
2 changes: 1 addition & 1 deletion miden-tx/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ path = "tests/integration/main.rs"

[features]
async = ["winter-maybe-async/async"]
concurrent = ["miden-lib/concurrent", "miden-objects/concurrent", "miden-prover/concurrent", "std"]
concurrent = ["miden-prover/concurrent", "std"]
default = ["std"]
std = ["miden-lib/std", "miden-objects/std", "miden-prover/std", "miden-verifier/std", "vm-processor/std"]
testing = ["miden-objects/testing", "miden-lib/testing", "vm-processor/testing", "dep:rand_chacha"]
Expand Down
2 changes: 1 addition & 1 deletion objects/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ harness = false
bench = false

[features]
concurrent = ["std"]
default = ["std"]
std = ["assembly/std", "miden-crypto/std", "miden-verifier/std", "vm-core/std", "vm-processor/std", "dep:toml", "dep:serde"]
testing = ["dep:winter-rand-utils", "dep:rand", "dep:rand_xoshiro"]
Expand All @@ -44,6 +43,7 @@ winter-rand-utils = { version = "0.10", optional = true }
getrandom = { version = "0.2", features = ["js"] }

[dev-dependencies]
pprof = { version = "0.14.0", default-features = false, features = ["criterion", "flamegraph"] }
anyhow = { version = "1.0.93", default-features = false, features = ["std", "backtrace"]}
assert_matches = { workspace = true }
criterion = { version = "0.5", default-features = false, features = ["html_reports"] }
Expand Down
Loading
Loading