feat: add creation of onchain notes

[mFragaBA]

Updates create_basic_fungible_faucet and create_basic_wallet to take an extra parameter that determines the account storage type (i.e. whether the account is stored onchain or offchain).

This is needed to create onchain stored accounts on miden client.

related to #171 from miden-client

[bobbinth]

Is this ready for review?

[mFragaBA]

Is this ready for review?

yea, I was waiting for CI to pass 😅. Also I mentioned on discord an issue I've had when testing this change on miden client. I'm getting an account hash mismatch error when I try to run a mint transaction against an onchain faucet. Perhaps I'm missing something else here in miden-base.

Building proven transaction error: Proven transaction account_final_hash 0x45c9f037a4a14b82f22811c922be778b67269165c9f1dc88552e10406fec9379 and account_details.hash must match 0x5b6dd5c0bec82c82d9f3ee0417fc15cc86f9e032aa3c2852946da05712e2b6c7.

more details here

[bobbinth]

Also I mentioned on discord an issue I've had when testing this change on miden client. I'm getting an account hash mismatch error when I try to run a mint transaction against an onchain faucet. Perhaps I'm missing something else here in miden-base.

Is the on-chain faucet "new" (i.e., was created not during genesis but by creating a new account). If so, the issue may be related to #529 (comment).

[bobbinth]

Looks good! Thank you!

Not related to this PR: account_type and account_storage_type seems too similar. Maybe we should rename account_storage_type into account_storage_mode.

[bobbinth]

minor nit: I would probably move account_storage_type up to be before auth_scheme.

[mFragaBA]

changed!

[mFragaBA]

Is the on-chain faucet "new" (i.e., was created not during genesis but by creating a new account). If so, the issue may be related to #529 (comment).

It is indeed! I'm now trying to replicate the changes on that PR and see if it gets fixed

UPDATE: tried cherry picking the first two commits from that PR (assuming that's where the fix was and later on refactors took place) and I'm still getting the same error