feat: add creation of onchain notes

miden-lib/src/accounts/faucets/mod.rs

@@ -19,7 +19,7 @@ const MAX_MAX_SUPPLY: u64 = (1 << 63) - 1;
 const MAX_DECIMALS: u8 = 12;
 
 /// Creates a new faucet account with basic fungible faucet interface,
-/// specified authentication scheme, and provided meta data (token symbol, decimals, max supply).
+/// specified authentication scheme, account storage type, and provided meta data (token symbol, decimals, max supply).
 ///
 /// The basic faucet interface exposes two procedures:
 /// - `distribute`, which mints an assets and create a note for the provided recipient.
@@ -36,6 +36,7 @@ pub fn create_basic_fungible_faucet(
     decimals: u8,
     max_supply: Felt,
     auth_scheme: AuthScheme,
+    account_storage_type: AccountStorageType,
 ) -> Result<(Account, Word), AccountError> {
     // Atm we only have RpoFalcon512 as authentication scheme and this is also the default in the
     // faucet contract, so we can just use the public key as storage slot 0.
@@ -85,7 +86,7 @@ pub fn create_basic_fungible_faucet(
     let account_seed = AccountId::get_account_seed(
         init_seed,
         AccountType::FungibleFaucet,
-        AccountStorageType::OffChain,
+        account_storage_type,
         account_code.root(),
         account_storage.root(),
     )?;

miden-lib/src/accounts/wallets/mod.rs

@@ -15,7 +15,7 @@ use super::{AuthScheme, TransactionKernel};
 // BASIC WALLET
 // ================================================================================================
 
-/// Creates a new account with basic wallet interface and the specified authentication scheme.
+/// Creates a new account with basic wallet interface, the specified authentication scheme and the account storage type.
 /// Basic wallets can be specified to have either mutable or immutable code.
 ///
 /// The basic wallet interface exposes two procedures:
@@ -30,6 +30,7 @@ pub fn create_basic_wallet(
     init_seed: [u8; 32],
     auth_scheme: AuthScheme,
     account_type: AccountType,
+    account_storage_type: AccountStorageType,
 ) -> Result<(Account, Word), AccountError> {
     if matches!(account_type, AccountType::FungibleFaucet | AccountType::NonFungibleFaucet) {
         return Err(AccountError::AccountIdInvalidFieldElement(
@@ -68,7 +69,7 @@ pub fn create_basic_wallet(
     let account_seed = AccountId::get_account_seed(
         init_seed,
         account_type,
-        AccountStorageType::OffChain,
+        account_storage_type,
         account_code.root(),
         account_storage.root(),
     )?;

miden-tx/tests/integration/scripts/faucet.rs

@@ -5,7 +5,7 @@ use miden_lib::{
 };
 use miden_objects::{
     accounts::{
-        Account, AccountCode, AccountId, AccountStorage, SlotItem, StorageSlot,
+        Account, AccountCode, AccountId, AccountStorage, AccountStorageType, SlotItem, StorageSlot,
         ACCOUNT_ID_FUNGIBLE_FAUCET_OFF_CHAIN,
     },
     assembly::{ModuleAst, ProgramAst},
@@ -244,10 +244,17 @@ fn faucet_contract_creation() {
     let token_symbol_string = "POL";
     let token_symbol = TokenSymbol::try_from(token_symbol_string).unwrap();
     let decimals = 2u8;
-
-    let (faucet_account, _) =
-        create_basic_fungible_faucet(init_seed, token_symbol, decimals, max_supply, auth_scheme)
-            .unwrap();
+    let storage_type = AccountStorageType::OffChain;
+
+    let (faucet_account, _) = create_basic_fungible_faucet(
+        init_seed,
+        token_symbol,
+        decimals,
+        max_supply,
+        auth_scheme,
+        storage_type,
+    )
+    .unwrap();
 
     // check that max_supply (slot 1) is 123
     assert_eq!(

miden-tx/tests/integration/wallet/mod.rs

@@ -191,7 +191,7 @@ fn prove_send_asset_via_wallet() {
 #[cfg(not(target_arch = "wasm32"))]
 #[test]
 fn wallet_creation() {
-    use miden_objects::accounts::{AccountType, ACCOUNT_ID_SENDER};
+    use miden_objects::accounts::{AccountStorageType, AccountType, ACCOUNT_ID_SENDER};
 
     // we need a Falcon Public Key to create the wallet account
     let seed = [0_u8; 32];
@@ -207,9 +207,11 @@ fn wallet_creation() {
         204, 149, 90, 166, 68, 100, 73, 106, 168, 125, 237, 138, 16,
     ];
 
+    let account_type = AccountType::RegularAccountImmutableCode;
+    let storage_type = AccountStorageType::OffChain;
+
     let (wallet, _) =
-        create_basic_wallet(init_seed, auth_scheme, AccountType::RegularAccountImmutableCode)
-            .unwrap();
+        create_basic_wallet(init_seed, auth_scheme, account_type, storage_type).unwrap();
 
     // sender_account_id not relevant here, just to create a default account code
     let sender_account_id = AccountId::try_from(ACCOUNT_ID_SENDER).unwrap();