feat: Add after_block_num field to NoteFile::NoteDetails
#823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
igamigo
approved these changes
Aug 9, 2024
objects/src/notes/file.rs
Outdated
Comment on lines
13
to
15
| /// The note has not yet been recorded on chain. | ||
| /// | ||
| /// An optional tag is included for note tracking. |
There was a problem hiding this comment.
We should add to this doc comment explaining the new field
bobbinth
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by @bobbinth in his comment on the note importing issue, a new field that kept track of a possible block number where a note was committed was needed. With this change we don't need to sync a note from block 0 and now have a lower bound.