Structure Factors with amrex::FFT #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@changhokim @HyuntaeJung if you do any further tests or simulations please use this branch and let me know if you see any issues. The goal here is to use the amrex::FFT parallel FFT backend instead of heffte/fftw/rocFFT, etc... All my testing so far shows no change in results. Make sure to update amrex as well. |
|
I still need to fix the unpacking case when Nx=1 (and the spectral domain is Ny/2+1) |
…ncated FFT into a full multifab. In these cases the spectral box is from Ny/2+1 since there is only 1 cell in x, and analogous for the Nx=Ny=1 cases, the spectral box here is Nz/2+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace FFTW and heffte with amrex::FFT.
I also changed the way flattened SF's work (slices, vertical averages, and surface coverage) - they are no longer rotated to z-normal, it will work with any project_dir and the flattened SF plotfile will have the appropriate layout (not always z-normal).
Also there is a lot of miscellaneous cleanup of unused variables, files, and function arguments.