fix blurry rotations (issue #24) by filling all 4 images from unrotat… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m unrotated but in different order
kalwalt
added
enhancement
|
@XiaNi I will look into this very soon! We have released v. 3.0.0 so i will have more time to test your PR. |
|
@XiaNi How can i test this? How do you visualize the pattern file? |
|
@kalwalt Check here, right side of marker there will be stripe with preview. |
|
@XiaNi thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix blurry rotations (issue #24) by filling all 4 images from unrotated but in different order
What kind of change does this PR introduce?
Can it be referenced to an Issue? If so what is the issue # ?
#24
How can we test it?
generate file and checkout
Summary
it should improve marker detection (i hope)
Does this PR introduce a breaking change?
no
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Other information