Remove redundant pipeline variable #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
jtracey93
approved these changes
Jun 10, 2024
oZakari
approved these changes
Jun 10, 2024
jaredfholgate
added a commit
to Azure/alz-terraform-accelerator
that referenced
this pull request
Jun 11, 2024
<!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary This PR updates the docs to reflect the deprecation of MSI auth support for ADO. It also removed the ci cd files which have been migrated to the bootstrap module. Sister PRs: * Azure/accelerator-bootstrap-modules#23 * Azure/ALZ-PowerShell-Module#116 ## This PR fixes/adds/changes/removes 1. #40 ### Breaking Changes This will have a minor version increment since we are removing the ci cd files, but the actual starter module code is not changing. ## Testing Evidence Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate). ## As part of this Pull Request I have - [ ] Checked for duplicate [Pull Requests](https://github.com/Azure/alz-terraform-accelerator/pulls) - [ ] Associated it with relevant [issues](https://github.com/Azure/alz-terraform-accelerator/issues), for tracking and closure. - [ ] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/alz-terraform-accelerator/tree/main) - [ ] Performed testing and provided evidence. - [ ] Updated relevant and associated documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
We are removing a pipeline path variable that is no longer required.
Here is a successful e2e test run with the updated bootstrap code: https://github.com/Azure/accelerator-bootstrap-modules/actions/runs/9450687525/job/26029889532
These are the sister PRs related to this:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.