Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSI references and CI / CD files #152

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

jaredfholgate
Copy link
Member

Overview/Summary

This PR updates the docs to reflect the deprecation of MSI auth support for ADO.

It also removed the ci cd files which have been migrated to the bootstrap module.

Sister PRs:

This PR fixes/adds/changes/removes

  1. Feature Request: Remove MSI Auth Option for Azure DevOps ALZ-PowerShell-Module#168

Breaking Changes

This will have a minor version increment since we are removing the ci cd files, but the actual starter module code is not changing.

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate merged commit 876954e into main Jun 11, 2024
4 checks passed
@jaredfholgate jaredfholgate deleted the migrate-cicd-to-bootstrap branch June 11, 2024 10:11
jaredfholgate added a commit to Azure/ALZ-PowerShell-Module that referenced this pull request Jun 11, 2024
# Pull Request

## Description

We are removing a pipeline path variable that is no longer required.

Here is a successful e2e test run with the updated bootstrap code:
https://github.com/Azure/accelerator-bootstrap-modules/actions/runs/9450687525/job/26029889532

These are the sister PRs related to this: 

* Azure/accelerator-bootstrap-modules#23
* Azure/alz-terraform-accelerator#152

## License

By submitting this pull request, I confirm that my contribution is made
under the terms of the projects associated license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants